From a13e7d670db70a3073633d4894015c2053018dc9 Mon Sep 17 00:00:00 2001 From: Patrick McDermott Date: Wed, 25 Oct 2017 11:33:05 -0400 Subject: mq_notebook_remove_page(): Destroy widgets after updating positions Fixes uses after free and warnings and errors from GLib and GTK+. --- diff --git a/src/notebook.c b/src/notebook.c index f646b1a..b4e2864 100644 --- a/src/notebook.c +++ b/src/notebook.c @@ -423,14 +423,14 @@ mq_notebook_remove_page(MqNotebook *notebook, MqTabPage *page) { find_node(notebook, page); - gtk_notebook_remove_page(GTK_NOTEBOOK(notebook), - mq_tree_position(notebook->found_node) - 1); - mq_tree_remove_allocated(MQ_TREE(notebook->found_node)); mq_tree_foreach_from(MQ_TREE(notebook->found_node), update_position, NULL); + gtk_notebook_remove_page(GTK_NOTEBOOK(notebook), + mq_tree_position(notebook->found_node)); + g_free(notebook->found_node); } -- cgit v0.9.1