From 7c43696d8473307da50455fa972be9cc9873ccb7 Mon Sep 17 00:00:00 2001 From: Patrick McDermott Date: Sat, 04 Nov 2017 22:36:49 -0400 Subject: about:profiles: Allocate room for trailing NULL in string vector Fixes a heap overflow. --- diff --git a/src/schemes/about/profiles.c b/src/schemes/about/profiles.c index 4439220..3cb0709 100644 --- a/src/schemes/about/profiles.c +++ b/src/schemes/about/profiles.c @@ -92,7 +92,7 @@ generate_document(MqProfiles *profiles, gboolean adding) gsize i; ids = mq_profiles_get_profiles(profiles, &length); - divs = g_new(gchar *, length + (adding ? 1 : 0)); + divs = g_new(gchar *, length + (adding ? 1 : 0) + 1); for (i = 0; i < length; ++i) { divs[i] = generate_div(profiles, ids[i]); } -- cgit v0.9.1