From 608a85bf14be409af5e587b3e61782805a11fa47 Mon Sep 17 00:00:00 2001 From: P. J. McDermott Date: Tue, 02 Oct 2018 18:00:33 -0400 Subject: MqTabLabel: Only hide popover on close if it's shown Fixes: (marquee:...): Gtk-CRITICAL **: gtk_widget_hide: assertion 'GTK_IS_WIDGET (widget)' failed --- diff --git a/src/tab-label.c b/src/tab-label.c index 7680532..8ada3dd 100644 --- a/src/tab-label.c +++ b/src/tab-label.c @@ -70,7 +70,12 @@ reload_tab_clicked_cb(GtkWidget G_GNUC_UNUSED *button, MqTabLabel *tab_label) static void close_clicked_cb(GtkWidget G_GNUC_UNUSED *button, MqTabLabel *tab_label) { - gtk_widget_hide(tab_label->popover); + if (tab_label->popover) { + /* This callback handles both the close button on the tab label + * and the one on the popover. Only hide the popover if it's + * shown. */ + gtk_widget_hide(tab_label->popover); + } mq_tab_page_close(tab_label->tab_page); } -- cgit v0.9.1