Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | mq_tree_insert_child*(), mq_tree_insert_sibling*(): Rename to mq_tree_append_*() | Patrick McDermott | 2017-10-24 | 3 | -11/+11 |
| | |||||
* | mq_tree_insert_sibling*(): Append rather than insert sibling | Patrick McDermott | 2017-10-24 | 1 | -10/+9 |
| | |||||
* | mq_tree_foreach_from(): Fix upward traversal | Patrick McDermott | 2017-10-24 | 1 | -8/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | Steps to reproduce bug: 1. From tab 1, append a new child 2. From tab 1, insert a new sibling 3. From tab 1, insert a new sibling The position of the last tab (the next sibling of the new tab inserted in step 3) gets updated twice. Tree debugging output: Traversing tree from position, starting at 0x12bf620 0x12bf620 0x1272f80 0x1272f80 Inserted sibling 0x12bf620, new tree (size 5): 0xe7f7f0 (size 5, position 0) 0xed3e10 (size 2, position 1) 0x114ef40 (size 1, position 2) 0x12bf620 (size 1, position 3) 0x1272f80 (size 1, position 5) | ||||
* | MqNotebook: Drop a G_GNUC_UNUSED attribute macro | Patrick McDermott | 2017-10-24 | 1 | -2/+1 |
| | |||||
* | mq_tree_insert_sibling*(): Fix new node position | Patrick McDermott | 2017-10-24 | 1 | -1/+1 |
| | |||||
* | MqTree: Add inserted node address to debugging output | Patrick McDermott | 2017-10-24 | 1 | -6/+5 |
| | |||||
* | MqTree: Add sizes and positions to insertion dbg output | Patrick McDermott | 2017-10-24 | 1 | -1/+2 |
| | |||||
* | MqNotebook, MqTabLabel, MqMainMenu: Open new tabs as siblings, not children | Patrick McDermott | 2017-10-24 | 3 | -4/+5 |
| | | | | This reverts commit c8eb35b and makes further changes. | ||||
* | mq_notebook_insert_*(): Optionally switch to new tab | Patrick McDermott | 2017-10-24 | 6 | -23/+47 |
| | | | | And update calls. | ||||
* | MqNotebook: Restructure tab tree view creation code a little | Patrick McDermott | 2017-10-24 | 1 | -4/+8 |
| | | | | Add blank lines for clarity and improve organization. | ||||
* | MqNotebook Use gtk_tree_selection_select_iter() | Patrick McDermott | 2017-10-24 | 1 | -13/+16 |
| | | | | | | Similar to commit 505f7bd, but a little less hairy and invasive. gtk_tree_view_expand_all() must be called before gtk_tree_selection_select_iter(). | ||||
* | Revert "MqNotebook: Try to use gtk_tree_selection_select_iter()" | Patrick McDermott | 2017-10-24 | 1 | -33/+29 |
| | | | | This reverts commit 505f7bd3f82bffe555f27d5dba4f71d845b8a9b4. | ||||
* | MqNotebook: Try to use gtk_tree_selection_select_iter() | Patrick McDermott | 2017-10-24 | 1 | -29/+33 |
| | |||||
* | mq_notebook_set_current_page(): Make page_num 1-based | Patrick McDermott | 2017-10-24 | 1 | -3/+3 |
| | |||||
* | MqNotebook: Set current page on tab tree row activation | Patrick McDermott | 2017-10-24 | 1 | -5/+4 |
| | | | | Now with no crashing! | ||||
* | MqNotebook: Add tab position to tree store | Patrick McDermott | 2017-10-24 | 1 | -6/+10 |
| | |||||
* | [WIP] MqNotebook: Rewrite tab tree row activation callback | Patrick McDermott | 2017-10-24 | 1 | -19/+11 |
| | | | | Just prints the tab title without changing to the tab. | ||||
* | MqNotebook: Add comment and debugging output for bug | Patrick McDermott | 2017-10-24 | 1 | -0/+13 |
| | |||||
* | MqTree: Improve tree traversal debugging output | Patrick McDermott | 2017-10-23 | 1 | -3/+3 |
| | |||||
* | mq_tree_insert_*(): Fix position updating tree traversal | Patrick McDermott | 2017-10-23 | 1 | -9/+15 |
| | | | | Just use mq_tree_foreach_from() now. | ||||
* | mq_tree_foreach_from(): Fix tree traversal | Patrick McDermott | 2017-10-23 | 1 | -19/+14 |
| | |||||
* | MqTree: Add foreach debugging output | Patrick McDermott | 2017-10-23 | 1 | -0/+20 |
| | |||||
* | MqTree: Fix some foreach recursion | Patrick McDermott | 2017-10-23 | 1 | -11/+0 |
| | |||||
* | mq_tree_insert_*(): Add debugging output | Patrick McDermott | 2017-10-23 | 1 | -0/+49 |
| | |||||
* | mq_tree_seek(): Fix assertion failures in recursive calls | Patrick McDermott | 2017-10-23 | 1 | -7/+13 |
| | |||||
* | mq_tree_seek(): Split assertion | Patrick McDermott | 2017-10-23 | 1 | -1/+2 |
| | |||||
* | mq_notebook_set_current_page(): Fix mq_tree_seek() offset argument | Patrick McDermott | 2017-10-23 | 1 | -1/+1 |
| | |||||
* | MqNotebook: Add tab tree popover | Patrick McDermott | 2017-10-23 | 1 | -0/+102 |
| | |||||
* | mq_tree_next(): Fix | Patrick McDermott | 2017-10-23 | 1 | -1/+1 |
| | |||||
* | mq_tree_foreach_child(): Remove function | Patrick McDermott | 2017-10-23 | 2 | -24/+0 |
| | |||||
* | mq_tree_first_child(): New macro | Patrick McDermott | 2017-10-23 | 1 | -0/+2 |
| | |||||
* | mq_notebook_set_current_page(): New function | Patrick McDermott | 2017-10-23 | 2 | -0/+13 |
| | |||||
* | MqNotebook: Make new tab button insert children, not siblings | Patrick McDermott | 2017-10-23 | 1 | -1/+1 |
| | |||||
* | MqNotebook: Update positions of tabs after inserted tab | Patrick McDermott | 2017-10-23 | 1 | -2/+10 |
| | |||||
* | mq_tree_foreach_child(): Loop over node's children, not root's | Patrick McDermott | 2017-10-23 | 1 | -1/+1 |
| | |||||
* | mq_tree_foreach_from(): New function | Patrick McDermott | 2017-10-23 | 2 | -0/+36 |
| | |||||
* | MqTree: Reduce code in foreach*() static functions | Patrick McDermott | 2017-10-23 | 1 | -20/+12 |
| | |||||
* | MqWindow: Drop notebook positions update callback | Patrick McDermott | 2017-10-23 | 1 | -16/+0 |
| | |||||
* | mq_tree_foreach*(): Accept only one user data argument | Patrick McDermott | 2017-10-23 | 3 | -40/+25 |
| | | | | | | | | | And update MqNotebook. The va_copy()s didn't seem to work. va_arg() in MqNotebook's find_node_compare() returned garbage, preventing the node from being found and causing the assertion in find_node() (as called by mq_notebook_insert_sibling() and mq_notebook_insert_child()) to fail. | ||||
* | MqNotebook: Add (non-functional) tab list button | Patrick McDermott | 2017-10-23 | 1 | -0/+9 |
| | |||||
* | MqNotebook: Add new tab button | Patrick McDermott | 2017-10-23 | 1 | -0/+18 |
| | |||||
* | mq_tree_insert_root_allocated(): Set node size | Patrick McDermott | 2017-10-23 | 1 | -0/+1 |
| | |||||
* | mq_notebook_get_n_pages(): Fix parentheses | Patrick McDermott | 2017-10-23 | 1 | -1/+1 |
| | |||||
* | mq_window_get_num_tabs(): Use mq_notebook_get_n_pages() | Patrick McDermott | 2017-10-23 | 1 | -2/+1 |
| | |||||
* | mq_notebook_get_n_pages(): New function | Patrick McDermott | 2017-10-23 | 2 | -0/+9 |
| | |||||
* | mq_tree_size(), mq_tree_position(): Fix conditional expressions | Patrick McDermott | 2017-10-23 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | Fixes: CC src/marquee-notebook.o In file included from src/notebook.c:29:0: src/notebook.c: In function ‘mq_notebook_get_n_pages’: src/tree.h:67:70: warning: pointer/integer type mismatch in conditional expression #define mq_tree_size(node) ((node) ? (((MqTree *) (node))->size) : NULL) ^ src/notebook.c:253:9: note: in expansion of macro ‘mq_tree_size’ return mq_tree_size(MQ_TREE(notebook->tree)); ^ src/notebook.c:253:2: warning: return makes integer from pointer without a cast return mq_tree_size(MQ_TREE(notebook->tree)); ^ | ||||
* | mq_window_[gs]et_current_tab(): Remove functions | Patrick McDermott | 2017-10-23 | 2 | -20/+0 |
| | |||||
* | mq_window_update_tab_title(): Remove function | Patrick McDermott | 2017-10-23 | 2 | -12/+0 |
| | |||||
* | MqTabPage: Use mq_notebook_update_tab_title() | Patrick McDermott | 2017-10-23 | 1 | -1/+4 |
| | |||||
* | mq_notebook_update_tab_title(): New function | Patrick McDermott | 2017-10-23 | 2 | -0/+16 |
| |