From 12c50f7939c02db85f05830c4b9fccf464b3977a Mon Sep 17 00:00:00 2001
From: Francis Rowe <info@gluglug.org.uk>
Date: Wed, 10 Jun 2015 20:30:48 -0400
Subject: all script: use a standard style

Based on the style used for the script in
resources/scripts/helpers/build/release/
---
(limited to 'resources/scripts/helpers/build/module')

diff --git a/resources/scripts/helpers/build/module/bucts b/resources/scripts/helpers/build/module/bucts
index 34e1a37..8f2a49a 100755
--- a/resources/scripts/helpers/build/module/bucts
+++ b/resources/scripts/helpers/build/module/bucts
@@ -29,7 +29,7 @@ set -u -e
 
 printf "Building bucts\n"
 
-cd bucts/
+cd "bucts/"
 
 buildtype="unknown"
 if (( $# != 1 )); then
@@ -38,19 +38,19 @@ else
 	buildtype="static"
 fi
 
-if [ "$buildtype" = "static" ]; then
-	patch Makefile < ../resources/bucts/patch/staticlink.diff
+if [ "${buildtype}" = "static" ]; then
+	patch "Makefile" < "../resources/bucts/patch/staticlink.diff"
 fi
 
 make clean
 make
 
-if [ "$buildtype" = "static" ]; then
-	patch Makefile -R < ../resources/bucts/patch/staticlink.diff
+if [ "${buildtype}" = "static" ]; then
+	patch "Makefile" -R < "../resources/bucts/patch/staticlink.diff"
 fi
 
 # done. go back to main directory
-cd ../
+cd "../"
 
 printf "\n\n"
 
diff --git a/resources/scripts/helpers/build/module/coreboot b/resources/scripts/helpers/build/module/coreboot
index 5a6174f..3d93c8d 100755
--- a/resources/scripts/helpers/build/module/coreboot
+++ b/resources/scripts/helpers/build/module/coreboot
@@ -29,18 +29,18 @@ set -u -e
 
 printf "Building the utilities in coreboot\n"
 
-cd coreboot
+cd "coreboot/"
 
 # -----------------------------------------
 # Build the utilities required by libreboot
 # -----------------------------------------
 
 # cbfstool
-cd util/cbfstool/
+cd "util/cbfstool/"
 make
 
 # done. go back to coreboot dir
-cd ../../
+cd "../../"
 
 # -------------------------------------
 # build reference crossGCC for coreboot
@@ -48,7 +48,7 @@ cd ../../
 make crossgcc-i386
 
 # done. go back to main libreboot_src directory
-cd ../
+cd "../"
 
 printf "\n\n"
 
diff --git a/resources/scripts/helpers/build/module/flashrom b/resources/scripts/helpers/build/module/flashrom
index a6cf612..0d2d1bf 100755
--- a/resources/scripts/helpers/build/module/flashrom
+++ b/resources/scripts/helpers/build/module/flashrom
@@ -29,20 +29,20 @@ set -u -e
 
 printf "Building flashrom\n"
 
-cd flashrom/
+cd "flashrom/"
 
 make clean
 if (( $# != 1 )); then
 	make
 else
-	if [ "$1" = "static" ]; then
+	if [ "${1}" = "static" ]; then
 		make SHARED=0 CC='gcc -static'
 	else
 		make
 	fi
 fi
 
-mv flashrom flashrom_normal
+mv "flashrom" "flashrom_normal"
 
 # build patched binaries for MX25L1605D and SST25VF016B flash chips
 # - these patches are needed for initial installation on an X60 or T60
@@ -50,18 +50,18 @@ mv flashrom flashrom_normal
 for patchname in "lenovobios_macronix" "lenovobios_sst"
 do
 	# first remove the existing build
-	rm -f flashrom_"$patchname"
+	rm -f "flashrom_${patchname}"
 	
 	# backup the unpatched flashchips.c (it will be patched)
-	cp flashchips.c flashchips.c_
+	cp "flashchips.c" "flashchips.c_"
 	# patch flashchips.c
-	patch flashchips.c < ../resources/flashrom/patch/"$patchname".diff
+	patch "flashchips.c" < "../resources/flashrom/patch/${patchname}.diff"
 	
 	make clean
 	if (( $# != 1 )); then
 		make
 	else
-		if [ "$1" = "static" ]; then
+		if [ "${1}" = "static" ]; then
 			make SHARED=0 CC='gcc -static'
 		else
 			make
@@ -69,16 +69,16 @@ do
 	fi
 	
 	# Rename the binary based on the patch name
-	mv flashrom flashrom_"$patchname"
+	mv "flashrom" "flashrom_${patchname}"
 	
 	# restore unpatched flashchips.c
-	rm -f flashchips.c
-	mv flashchips.c_ flashchips.c
+	rm -f "flashchips.c"
+	mv "flashchips.c_" "flashchips.c"
 done
 
-mv flashrom_normal flashrom
+mv "flashrom_normal" "flashrom"
 
-cd ../
+cd "../"
 
 printf "\n\n"
 
diff --git a/resources/scripts/helpers/build/module/grub b/resources/scripts/helpers/build/module/grub
index 73f36e7..e6b548a 100755
--- a/resources/scripts/helpers/build/module/grub
+++ b/resources/scripts/helpers/build/module/grub
@@ -29,10 +29,10 @@ set -u -e
 
 printf "Building GRUB\n"
 
-cd grub/
+cd "grub/"
 
 # clean it first
-[[ -f Makefile ]] && make clean
+[[ -f Makefile ]] && make distclean
 
 # build grub
 ./autogen.sh
@@ -42,6 +42,6 @@ make
 printf "\n\n"
 
 # done. go back to main directory
-cd ../
+cd "../"
 
 # ------------------- DONE ----------------------
diff --git a/resources/scripts/helpers/build/module/i945pwm b/resources/scripts/helpers/build/module/i945pwm
index 657a7b4..0c5200c 100755
--- a/resources/scripts/helpers/build/module/i945pwm
+++ b/resources/scripts/helpers/build/module/i945pwm
@@ -29,14 +29,14 @@ set -u -e
 
 printf "Building i945-pwm\n"
 
-cd resources/utilities/i945-pwm/
+cd "resources/utilities/i945-pwm/"
 
 make clean
 # build it
 make
 
 # done. go back to main directory
-cd ../../../
+cd "../../../"
 
 printf "\n\n"
 
diff --git a/resources/scripts/helpers/build/module/ich9deblob b/resources/scripts/helpers/build/module/ich9deblob
index 25cf97b..d1d0d2f 100755
--- a/resources/scripts/helpers/build/module/ich9deblob
+++ b/resources/scripts/helpers/build/module/ich9deblob
@@ -29,7 +29,7 @@ set -u -e
 
 printf "Building ich9deblob\n"
 
-cd resources/utilities/ich9deblob
+cd "resources/utilities/ich9deblob/"
 
 # clean it first
 make clean
@@ -38,7 +38,7 @@ make clean
 make
 
 # done. go back to main directory
-cd ../../../
+cd "../../../"
 
 printf "\n\n"
 
diff --git a/resources/scripts/helpers/build/module/memtest86plus b/resources/scripts/helpers/build/module/memtest86plus
index d6f52ef..8fd9c1d 100755
--- a/resources/scripts/helpers/build/module/memtest86plus
+++ b/resources/scripts/helpers/build/module/memtest86plus
@@ -29,7 +29,7 @@ set -u -e
 
 printf "Building MemTest86+\n"
 
-cd "memtest86+-5.01"/
+cd "memtest86+-5.01/"
 
 # clean it first
 make clean
@@ -38,7 +38,7 @@ make clean
 make
 
 # done. go back to main directory
-cd ../
+cd "../"
 
 printf "\n\n"
 
--
cgit v0.9.1