summaryrefslogtreecommitdiffstats
path: root/getgrub
diff options
context:
space:
mode:
authorFrancis Rowe <info@gluglug.org.uk>2015-02-13 22:46:19 (EST)
committer Francis Rowe <info@gluglug.org.uk>2015-02-13 22:46:19 (EST)
commit23c28a97add1866973eebe07c51c2ce4ceba0d94 (patch)
tree2d1897b6c36ec62f4c4e89438add8f648b280dfa /getgrub
parentdfbcec9d8674fe04521d3626e9245efcb41772ac (diff)
downloadlibreboot-23c28a97add1866973eebe07c51c2ce4ceba0d94.zip
libreboot-23c28a97add1866973eebe07c51c2ce4ceba0d94.tar.gz
libreboot-23c28a97add1866973eebe07c51c2ce4ceba0d94.tar.bz2
getgrub: add notes about work on longstanding bug in GRUB
Relating to vesamenu.c32 file support in the syslinux_configfile function of GRUB.
Diffstat (limited to 'getgrub')
-rwxr-xr-xgetgrub18
1 files changed, 18 insertions, 0 deletions
diff --git a/getgrub b/getgrub
index 709fe99..36b7336 100755
--- a/getgrub
+++ b/getgrub
@@ -49,6 +49,24 @@ git reset --hard 32cd33bd19348afb77ab849846e0b6d6157ea308
# Replace "GNU GRUB version" in GRUB screen with "FREE AS IN FREEDOM"
git am "../resources/grub/patch/0001-grub-core-normal-main.c-Display-FREE-AS-IN-FREEDOM-n.patch"
+## See these threads on grub-dev@gnu.org:
+## [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse
+## [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for initrd= option
+## These make vesamenu.c32 work (translation: Debian/Tails ISOLINUX) but they are
+## buggy at the moment; Trisquel ISOLINUX parsing fails with these patches, for instance:
+## "error: syntax error.", "error: Incorrect command."
+## The mailing list contains updated versions of the patches mentioned below
+## Work with Lunar^ on IRC on finishing the patch so that it fixes the issue
+## while not causing other regressions. Wait until this is merged in GRUB(upstream).
+# Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse
+# See https://savannah.gnu.org/bugs/index.php?44238
+# TODO: Remove this patch when it is upstreamed.
+# git am "../resources/grub/patch/0002-syslinux_parse-add-support-for-vesa-menu.c32.patch"
+# Behavior of syslinux_parse differs from SYSLINUX for initrd= option
+# See https://savannah.gnu.org/bugs/index.php?44239
+# TODO: Remove this patch when it is upstreamed.
+# git am "../resources/grub/patch/0003-syslinux_parse-keep-initrd-in-kernel-the-command-lin.patch"
+
cd ../
echo "FINISHED DOWNLOADING GRUB"